Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework of module inheritance #48

Merged
merged 5 commits into from
Dec 22, 2020
Merged

Rework of module inheritance #48

merged 5 commits into from
Dec 22, 2020

Conversation

da-h
Copy link
Owner

@da-h da-h commented Dec 7, 2020

This MR rewrites the way in which modules define inheritance.

In more Detail

  • the .default keyword was misleading in multiple ways and has been removed (Closes Replace default as special name with boilerplate inheritance #44)

  • enabling submodules (modules with modules beneath it)

  • changing the way relative modules are referenced. (Closes set_scope() with relative paths #29)
    Considering the register method of the module a.b.c.d.

  • test cases checking all of those features

    Before this MR:

    • .addional referenced a.b.c.additional (as typically one would use .default module constructs)
    • .. referenced a.b
    • . referenced a.b.c

    After this MR:

    • .addional references a.b.c.d.additional (as we allow submodules now)
    • .. references a.b.c
    • . is a noop.

@da-h da-h force-pushed the default-keyword/remove branch from af862b5 to 5403322 Compare December 7, 2020 17:43
@da-h da-h force-pushed the default-keyword/remove branch from 5403322 to 8804dad Compare December 7, 2020 17:56
@da-h da-h removed a link to an issue Dec 9, 2020
2 tasks
@da-h da-h force-pushed the default-keyword/remove branch 2 times, most recently from d7a1276 to 056a7ae Compare December 9, 2020 12:10
@da-h da-h changed the title WIP: Rework of module inheritance Rework of module inheritance Dec 9, 2020
@da-h da-h force-pushed the default-keyword/remove branch from 056a7ae to da4f56d Compare December 9, 2020 12:18
@da-h da-h force-pushed the default-keyword/remove branch from da4f56d to 600d09e Compare December 22, 2020 18:20
@da-h da-h requested a review from sbrodehl December 22, 2020 18:56
@da-h da-h added this to the v2.0 milestone Dec 22, 2020
@da-h da-h merged commit 185b202 into v2-dev Dec 22, 2020
@da-h da-h deleted the default-keyword/remove branch December 28, 2020 08:57
@da-h da-h mentioned this pull request Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace default as special name with boilerplate inheritance set_scope() with relative paths
2 participants