chore: change bundler to tsdown #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 561ecba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
iamchanii
commented
Dec 5, 2024
| @@ -1,4 +1,4 @@ | |||
| export function isEqual<T>(identify: (t: T) => string, a: T, b: T) { | |||
There was a problem hiding this comment.
To resolve TS9007: Function must have an explicit return type annotation with --isolatedDeclarations, add return type explicity.
| "files": [ | ||
| "dist", | ||
| "src", | ||
| "README.md" | ||
| ], | ||
| "scripts": { | ||
| "build": "nanobundle build", | ||
| "clean": "nanobundle clean", | ||
| "build": "tsdown", |
There was a problem hiding this comment.
For what I understood, clean script is not used in repository. I think it's an equivalence of the add clean option.
tonyfromundefined
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graplix is does not work correctly in a project that has set
"moduleResolution": "Node16"or"moduleResolution": "NodeNext"in its tsconfig.json. causes, compiled js/d.ts files are not including extensions.So I changed the bundler to tsdown from nanobundle for add extensions into compiled files with minimal changes. if you're not ready or don't want to adopt tsdown or whatever one, feel free close this pull request!