Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #11

Merged
merged 5 commits into from
Nov 10, 2015
Merged

Cleanup #11

merged 5 commits into from
Nov 10, 2015

Conversation

Tensho
Copy link
Contributor

@Tensho Tensho commented Nov 5, 2015

I've made some pre-refactoring before projects implementation. Because employee can work on the several projects in the same company, it's reasonable allow to specify projects per company in CV. For this feature we need to introduce groups in the form of the tree, where one node can contain many other nodes. In this case we can write something like this:

employment do
    company "Dream" do
      homepage "http://dream.com/"

      project "A" do
        homepage "http://project-a.com/"

        title "Rails developer"

        technologies "Ruby, Ruby on Rails"

        bulletin "B1."
        bulletin "B2."

        start_date "June 2015"
        end_date "Current"
      end

      project "B" do
        homepage "http://project-b.com/"

        title "JavaScript developer"

        technologies "Javascript, Ruby on Rails"

        bulletin "B3."
        bulletin "B4."

        start_date "June 2014"
        end_date "June 2015"
      end
    end
  end
end

## TODO

* Add support of the projects, because you can work on the several projects in the same company.

## Ports
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that would be a good idea. It seems like it would introduce a lot of complexity but would benefit users only in a few edge-case situations. I'd love to keep this tool as simple as possible.

@dabrorius
Copy link
Owner

Hi, thanks for the PR. Changes look great, I'm just not sure about the 'support for projects' part. Can you please remove that part and open a separate issue?

@Tensho
Copy link
Contributor Author

Tensho commented Nov 10, 2015

Remove from here, created separate issue #12.

@dabrorius
Copy link
Owner

Awesome, thanks! 👍

dabrorius added a commit that referenced this pull request Nov 10, 2015
@dabrorius dabrorius merged commit 71e7a72 into dabrorius:master Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants