feat: uniform post page login #4046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
AmarTrebinjac
requested review from
rebelchris,
omBratteng,
ilasw,
capJavert,
sshanzel and
nensidosari
|
Since we deleted the authModal completely and always redirect to onboarding now, I figured refactoring the showLogin would be a better option. I think all the above comments should be solved now. I did some E2E testing myself and everything seems OK, but please do check it yourselves @capJavert and @omBratteng, the more the merrier :) |
omBratteng
changed the title
omBratteng
approved these changes
Jan 21, 2025
rebelchris
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Just make sure to do critical flow testing and report in the doc once deployed:
https://dailydotdev.atlassian.net/wiki/spaces/HAN/pages/458096761/Critical+flows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This task is named "uniform post page login", but the changes here affect more than just post page as I directly modified the "LoginButton" that is used both in the CustomAuthBanner (mobile banner) and Navbar.
Chris mentions here that only login flow should be inside /onboarding to be able to leverage all onboarding steps. So unless we want the Navbar to pop the modal on other pages than /posts/, I say we keep it this way
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://mi-696.preview.app.daily.dev