feat: show toast when post is shared by user #4251
+105
−75
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| import React, { useEffect, useRef } from 'react'; | ||
| import { useRouter } from 'next/router'; | ||
| import Link from 'next/link'; | ||
| import { useAuthContext } from '../contexts/AuthContext'; | ||
| import { useToastNotification } from './useToastNotification'; | ||
| import { useContentPreferenceStatusQuery } from './contentPreference/useContentPreferenceStatusQuery'; | ||
| import { | ||
| ContentPreferenceStatus, | ||
| ContentPreferenceType, | ||
| } from '../graphql/contentPreference'; | ||
| import { useUserShortByIdQuery } from './user/useUserShortByIdQuery'; | ||
| import { useContentPreference } from './contentPreference/useContentPreference'; | ||
| import { ButtonSize } from '../components/buttons/common'; | ||
| import { ProfileImageSize, ProfilePicture } from '../components/ProfilePicture'; | ||
| import { Button } from '../components/buttons/Button'; | ||
| import { Typography, TypographyTag } from '../components/typography/Typography'; | ||
|
|
||
| const useSharedByToast = (): void => { | ||
| const hasShownToast = useRef(false); | ||
| const { user: currentUser, isAuthReady } = useAuthContext(); | ||
| const { query } = useRouter(); | ||
| const userId = (query?.userid as string) || null; | ||
| const isSameUser = !!userId && userId === currentUser?.id; | ||
| const { data: contentPreference, isPending } = | ||
| useContentPreferenceStatusQuery({ | ||
| id: userId, | ||
| entity: ContentPreferenceType.User, | ||
| }); | ||
| const { data: user } = useUserShortByIdQuery({ id: userId }); | ||
| const { follow } = useContentPreference({ showToastOnSuccess: true }); | ||
| const { displayToast, dismissToast } = useToastNotification(); | ||
| const isDataReady = isAuthReady || (currentUser && !isPending); | ||
|
|
||
| useEffect(() => { | ||
| if (!user || isSameUser || !isDataReady || hasShownToast.current) { | ||
| return; | ||
| } | ||
|
|
||
| const showFollow = | ||
| !!currentUser && | ||
| contentPreference?.status !== ContentPreferenceStatus.Follow; | ||
|
Comment on lines
+39
to
+41
There was a problem hiding this comment. Maybe we want to check even if the target user is currently blocked |
||
|
|
||
| setTimeout(() => { | ||
| hasShownToast.current = true; | ||
| displayToast( | ||
|
Comment on lines
+43
to
+45
There was a problem hiding this comment. I’m not really a fan of using setTimeout inside useEffect, but I think we should handle the case where a user lands on the page and then quickly navigates back to the home page. I suggest adding a ref to store the timerId, then clearing the timer on unmount. We should also clear it if the userId changes to prevent issues when navigating between shared posts. Wdyt? There was a problem hiding this comment. +1 we have to clear timeout, it introduces memory leaks |
||
| <div className="flex items-center gap-4 "> | ||
| <Link | ||
| onClick={() => dismissToast()} | ||
| className="flex items-center gap-2 " | ||
| href={`/${user.username}`} | ||
| > | ||
| <ProfilePicture user={user} size={ProfileImageSize.Medium} /> | ||
| <span> | ||
| <Typography tag={TypographyTag.Span} bold> | ||
| {user.name} | ||
| </Typography>{' '} | ||
| <Typography tag={TypographyTag.Span}>shared this post</Typography> | ||
| </span> | ||
| </Link> | ||
| {showFollow && ( | ||
| <Button | ||
| onClick={() => { | ||
| follow({ | ||
| entity: ContentPreferenceType.User, | ||
| id: user?.id, | ||
| entityName: `@${user.username}`, | ||
| }); | ||
| }} | ||
| className="bg-background-default text-text-primary" | ||
| size={ButtonSize.Small} | ||
| > | ||
| Follow | ||
| </Button> | ||
| )} | ||
| </div>, | ||
| ); | ||
| // Set a small timeout to ensure its shown after the page is loaded and won't be cleared by updates. | ||
| }, 1000); | ||
| }, [ | ||
| user, | ||
| contentPreference?.status, | ||
| hasShownToast, | ||
| displayToast, | ||
| dismissToast, | ||
| follow, | ||
| isSameUser, | ||
| isDataReady, | ||
| currentUser, | ||
| ]); | ||
| }; | ||
|
|
||
| export default useSharedByToast; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we currently blocking those queries if the post author is the current logged in user? We should avoid network calls in this case.