Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup pwa installation coming from extension and android #4254

Merged
merged 9 commits into from
Mar 4, 2025
Merged

chore: cleanup pwa installation coming from extension and android #4254

merged 9 commits into from
Mar 4, 2025
+9 −376

Conversation

sshanzel
Copy link
Member

@sshanzel sshanzel commented Mar 3, 2025 •
edited by github-actions bot
Loading

Changes

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://chore-cleanup-pwa.preview.app.daily.dev

@sshanzel sshanzel requested a review from a team as a code owner March 3, 2025 15:40
@vercel Vercel
Copy link

vercel bot commented Mar 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Mar 4, 2025 11:19am
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Mar 4, 2025 11:19am

rebelchris
rebelchris reviewed Mar 4, 2025
View reviewed changes
Copy link
Contributor

@rebelchris rebelchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just let me know what's up with the other ones that sounds the same XD?

packages/shared/src/components/onboarding/CreateFeedButton.tsx
OnboardingStep.InstallDesktop,
OnboardingStep.AndroidPWA,
].includes(activeScreen);
const CTAStep = [OnboardingStep.PWA, OnboardingStep.Extension].includes(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the PWA vs AndroidPWA?
Because the slack message says promote desktop PWA isn't it "PWA" one?

I just don't know what any of these mean now 😂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, got me confusing too, actually. The PWA is for the iOS one.

Copy link
Member Author

@sshanzel sshanzel Mar 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically looked at the key from what was requested to be cleaned up since we have 3 PWAs:

  • Desktop.
  • Android.
  • iOS.

First two needs to be cleaned up.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take the blame for the "PWA" key. Didn't think we'd be testing 3 different PWA's in the onboarding 😭

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok, no, it's all good just making sure as I would read it different now :P

AmarTrebinjac
AmarTrebinjac approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@AmarTrebinjac AmarTrebinjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can probably cleanup the pictures / videos from the image file as well.

Sad to see the desktop one go, the cat was cute 😭

@sshanzel
Copy link
Member Author

sshanzel commented Mar 4, 2025

Can probably cleanup the pictures / videos from the image file as well.

Sad to see the desktop one go, the cat was cute 😭

Imo, it is not the step that failed; it is the amount that makes it a bit overwhelming. But gotta cleanup nonetheless 🧹

ilasw
ilasw approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@ilasw ilasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good code wise ✅

@sshanzel
Copy link
Member Author

sshanzel commented Mar 4, 2025

I also took the liberty to cleanup more unused assets in the images.ts.

@sshanzel sshanzel merged commit 2f6fdac into main Mar 4, 2025
9 checks passed
@sshanzel sshanzel deleted the chore-cleanup-pwa branch March 4, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebelchris rebelchris rebelchris approved these changes

@ilasw ilasw ilasw approved these changes

@AmarTrebinjac AmarTrebinjac AmarTrebinjac approved these changes

@omBratteng omBratteng Awaiting requested review from omBratteng omBratteng is a code owner automatically assigned from dailydotdev/web-team

@capJavert capJavert Awaiting requested review from capJavert capJavert is a code owner automatically assigned from dailydotdev/web-team

@nensidosari nensidosari Awaiting requested review from nensidosari nensidosari is a code owner automatically assigned from dailydotdev/web-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sshanzel @rebelchris @ilasw @AmarTrebinjac