Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.10.2 #133

Closed
wants to merge 18 commits into from
Closed

Release 1.10.2 #133

wants to merge 18 commits into from

Conversation

bertfrees
Copy link
Member

@bertfrees bertfrees commented Jun 22, 2017

@rdeltour All the artifacts are staged. What is left to do now is to build the various packages. What is usually your workflow for that? Which packages do you build? Where do you upload a RC? Do you give the RC a non-snapshot version? Do you use the release plugin for the assembly? Do you update the release descriptor for the updater also for the RC?

These instructions could also go into the "super release script" I have made.

I have built the Windows ZIP, the EXE, the Mac OS ZIP, the DMG, the Linux ZIP, and the DEB.

This can definitely be made easier. Building them all at the same time is not possible, but when you try to build them one by one you end up building things more than once. This is part of #75.

I hope I got everything right. You normally do this, and different machines may give different results. But I guess we'll find out when testing.

Depends on:

bertfrees and others added 9 commits May 30, 2017 14:51
Disable generate-app-package, install-node, install-appdmg and
exec-appdmg executions.
It was already commented out, see
d706242
- org.apache.felix.main 5.6.2
- org.apache.felix.src 2.0.8

In addition, org.osgi.enterprise has been updated to 5.0.0 in framework
BoM.

This seems to have fixed the launch issue daisy/pipeline-mod-braille#135.
@bertfrees bertfrees mentioned this pull request Jun 22, 2017
37 tasks
@rdeltour
Copy link
Member

All the artifacts are staged. What is left to do now is to build the various packages. What is usually your workflow for that?

Essentially:

  • finalize the release notes
  • build the packages (Windows installer, macOS dmg, Linux zip)
  • upload the installers to a github release
  • send announcements

Which packages do you build?

As said above, one for each major OS (using the assembly profiles).

Where do you upload a RC?

I would upload directly to GitHub.

If/when we want to tests it before, I'd simply ask people to build their own packages with the assembly (the fixed versions are staged, so it should be the same package as you build).
A GitHub release can be marked as a "draft" and not published immediately; I don't know if the uploaded artifacts could be staged that way too for internal tests.

Do you give the RC a non-snapshot version?

If it's a proper public RC, yes. And I'd publish as a GitHub release with a "pre-release" flag. If it's just for our own internal tests, I'd do as described above.

Do you use the release plugin for the assembly?

I think I did both ways in the past (i.e. with the release plugin or manually). But in any case I don't push the artifacts to Maven Central (I may have added POM code to disable pushing these, not sure).

Do you update the release descriptor for the updater also for the RC?

I don't think we had the case already. I wouldn't update the descriptor for the RC.

- daisy202-validator
- [FIX] Attribute "shape" not allowed here
- Braille modules
- Improve launch-time stability
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes it look like it was a problem in the braille modules. The problem was indeed noticed only in the braille modules for some reason, but the fix had nothing to do with the braille modules.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Moved that under the "Framework" section.

### Modules

- Add basic tests for all scripts
- Re-enable all XSpec and and XProcSpec tests
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two are not relevant for users, maybe move to the maintainer section below?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, moved that in the "build maintenance" section.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. But I meant also the line above ;)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, not quite sure. Knowing that there are tests is useful and reassuring for users. Knowing that they're in XSpec and XProcSpec is more a developer things... 🤔

- [FIX] problem finding lame
- Utility modules
- [fileset-utils] change the actual base URI of documents in `px:fileset-load`
- [FIX] Circular dependency between `fileset-utils` and `mediatype-utils`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment regarding relevancy to users.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the line, since it can be seen as part of the "Cleanup dependencies" entry.

- [FIX] The "assert validity" option on dtbook-to-epub3 does not seem to work
- daisy202-validator
- [FIX] Attribute "shape" not allowed here
- Braille modules
Copy link
Member Author

@bertfrees bertfrees Aug 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more has happened since v1.10.0, but you probably didn't find all of the changes because not all of them have pull requests. By the way also things have happened between v1.10.0 and v1.9.16 of the braille modules which aren't in the release notes. (EDIT: Actually not much has happened between v1.9.16 and v1.10.0 after all, only documentation.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll create the release notes for the braille modules.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a while to find out what all the changes were about again and to summarize them. I'm more or less finished now but will push it somewhere tomorrow.

@rdeltour
Copy link
Member

Merged in master.

@rdeltour rdeltour closed this Aug 28, 2017
@rdeltour rdeltour deleted the release/1.10.2 branch August 28, 2017 06:51
@rdeltour rdeltour added this to the v1.10.2 milestone Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants