Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch does 2 things:
*chunk-size*
for lazy streams (the binding can now be set around thejson/parse-stream
call rather than around whatever seq-consumption code you were using).For context on the latter, I have a (weird) protocol that looks like this:
The issue is the producer of this JSON is fully lazy - i.e. it outputs one
, {"type": "blah"}
command at a time and "waits" for a response. Cheshire can almost parse this, and with this change it can fully parse this (assuming you set*chunk-size*
to 1). The root cause is just an issue with callingnextToken
before returning the element in the sequence (those two should be reversed).