Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renault Kangoo: Rescale SOC, current and power #218

Merged
merged 12 commits into from
May 12, 2024
Merged

Conversation

dalathegreat
Copy link
Owner

What

This PR fixes scaling on a few values, from user testing

Why

User grafitix on the Discord server noticed that some Kangoo values where incorrect.

  • SOC% had one decimal missing
  • Current value had one decimal missing
  • Power value was too large (due to current being wrong)

This PR fixes these three values for Kangoo packs

Copy link
Collaborator

@lenvm lenvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dalathegreat
Copy link
Owner Author

This one is still WIP, waiting for confirmation if SOC rescaling is needed or not

@lenvm lenvm marked this pull request as draft March 27, 2024 22:05
@dalathegreat dalathegreat marked this pull request as ready for review May 1, 2024 18:32
@dalathegreat dalathegreat merged commit 30fb23b into main May 12, 2024
48 checks passed
@dalathegreat dalathegreat deleted the bugfix/kangoo-values branch May 12, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants