Feature: Add configurable limit to charge/discharge on BYD Modbus #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cabooman
requested changes
May 7, 2024
|
Converting to draft, I want to investigate more on how to increase performance |
|
Ready for review, this is now extremely sped up! :) |
|
Looks good to me given the PR scope. I agree with Caboom on the need/suggestions for initialization refactoring; I had the same impulses. Glad to see reduced reliance upon memcpy. For the future: configurable limit for charge/discharge being expanded elsewhere. |
Cabooman
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR does two things:
Why
To be able to tune peak power from the webui on Fronius inverters
How
Using the std::min function to see which is smaller, User set limit OR battery value? We use the smallest one! This PR also removes all memcopy handling, and simplifies the register writing significantly