Improvement: Send cellmV when cell events are raised #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odlg
requested changes
May 12, 2024
| @@ -455,36 +455,36 @@ void update_values_battery() { //This function maps all the values fetched via | |||
|
|
|||
| // Start checking safeties. First up, cellvoltages! | |||
| if (battery_cell_deviation_mV > MAX_CELL_DEVIATION_MV) { | |||
| set_event(EVENT_CELL_DEVIATION_HIGH, 0); | |||
| set_event(EVENT_CELL_DEVIATION_HIGH, battery_cell_deviation_mV); | |||
There was a problem hiding this comment.
If (for some erroneous reason) min-cell voltage is 0, you will not see it here as the value will wrap around.
Perhaps some function to make value here somewhat logarithmic. Like 0-240 is mV difference and from 241 and up it is increasing value with 1 means 20mV for each. Another option is to make event values 16 bit?
There was a problem hiding this comment.
I think this is good enough, until we get the event value 16bit. Better than a 0, and sure, the edge cases wont be handled perfectly, but better than before atleast :)
|
Scrapping this PR, will rewrite it as a general safety handler to get rid of battery specific implementations! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR makes the cell over/under/deviation events easier to troubleshoot. Added to all battery types that were missing this.
Why
Now when for instance a cell overvoltage event is raised, it is hard to know what the value of the cell was when it occured.
How
Since the event can only get an u8 parsed (0-255), we shrink the cellvoltage by 20, and when reviewing the events you can simply add *20 to the value. (4250mV sent as 4250/20 = 212)