Bugfix/bmw i3 messages #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| report_value = 255; | ||
| } | ||
|
|
||
| set_event(EVENT_CELL_DEVIATION_HIGH, report_value); |
There was a problem hiding this comment.
Like I mentioned in the other PR, It would be good enough to just do
set_event(EVENT_CELL_DEVIATION_HIGH, battery_cell_deviation_mV);
here, since we raise an alarm if it goes over 250mv. And 250 fits into the u8, barely :)
There was a problem hiding this comment.
@odlg Anyways, I approved this PR, we can handle that discussion in the other PR!
dalathegreat
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixed fetching extra data and wait until data available before setting low voltage event. Use max cell voltage instead of average voltage. Reduced risk of making unneeded events.
Why
Make using BMW i3 batteries more robust.
How
Send different defined 0x6F1 messages and parse them as the type requested. Made logic regarding raising events more robust.