Fixing checkstyle errors

.gitignore

@@ -9,6 +9,8 @@
 target
 work
 
+.checkstyle
+
 # IntelliJ
 .idea/
 *.iml

src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildForm.java

@@ -67,14 +67,14 @@ public BuildForm(final PipelineBuild pipelineBuild) {
             dependencies.add(new BuildForm(downstream));
         }
         id = hashCode();
-        AbstractProject<?,?> project = pipelineBuild.getProject();
+        final AbstractProject<?, ?> project = pipelineBuild.getProject();
         projectId = project.getFullName().hashCode();
-        ParametersDefinitionProperty params = project.getProperty(ParametersDefinitionProperty.class);
-        ArrayList<String> paramList = new ArrayList<String>();
-        if(params != null) {
-	        for(String p : params.getParameterDefinitionNames()) {
-	        	paramList.add(p);
-	        }
+        final ParametersDefinitionProperty params = project.getProperty(ParametersDefinitionProperty.class);
+        final ArrayList<String> paramList = new ArrayList<String>();
+        if (params != null) {
+            for (String p : params.getParameterDefinitionNames()) {
+                paramList.add(p);
+            }
         }
         parameters = paramList;
     }
@@ -145,7 +145,7 @@ public Map<String, String> getParameters() {
     }
 
     public ArrayList<String> getParameterList() {
-    	return parameters;
+        return parameters;
     }
 
     public Integer getProjectId() {

src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView.java

@@ -40,8 +40,6 @@
 import hudson.model.Descriptor.FormException;
 import hudson.model.Hudson;
 import hudson.model.ParametersAction;
-import hudson.model.ParametersDefinitionProperty;
-import hudson.model.Project;
 import hudson.model.Run;
 import hudson.model.User;
 import hudson.model.View;
@@ -74,8 +72,9 @@
 import au.com.centrumsystems.hudson.plugin.util.ProjectUtil;
 
 /**
- * This view displays the set of jobs that are related based on their upstream\downstream relationships as a pipeline. Each build pipeline
- * becomes a row on the view.
+ * This view displays the set of jobs that are related
+ * based on their upstream\downstream relationships as a pipeline. Each
+ * build pipeline becomes a row on the view.
  *
  * @author Centrum Systems
  *
@@ -222,9 +221,9 @@ public void print(final TaskListener listener) {
      *            Indicates whether only the latest job will be triggered.
      * @param cssUrl
      *            URL for the custom CSS file.
-     *            
      * @param startsWithParameters
-     * 			  Indicates whether the first job of the pipeline takes parameters
+     *            Indicates whether the first job of the pipeline takes
+     *            parameters
      */
     public BuildPipelineView(final String name, final String buildViewTitle,
              final ProjectGridBuilder gridBuilder, final String noOfDisplayedBuilds,
@@ -266,7 +265,7 @@ public BuildPipelineView(final String name, final String buildViewTitle,
      * @param selectedJob
      *            the first job name in the pipeline. it can be set to null when gridBuilder is passed.
      * @param startsWithParameters
-     * 			  Indicates whether the first job of the pipeline takes parameters
+     *            indicates whether the first job of the pipeline takes parameters
      */
     @DataBoundConstructor
     public BuildPipelineView(final String name, final String buildViewTitle, final ProjectGridBuilder gridBuilder,

src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/DownstreamProjectGridBuilder.java

@@ -163,8 +163,8 @@ public boolean hasBuildPermission(BuildPipelineView owner) {
 
     @Override
     public boolean startsWithParameters(BuildPipelineView owner) {
-        AbstractProject<?,?> firstJob = this.getFirstJob(owner);
-        ParametersDefinitionProperty pdp = firstJob.getProperty(ParametersDefinitionProperty.class);
+        final AbstractProject<?, ?> firstJob = this.getFirstJob(owner);
+        final ParametersDefinitionProperty pdp = firstJob.getProperty(ParametersDefinitionProperty.class);
         return pdp != null;
     }
 

src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/dashboard/ReadOnlyBuildPipelineView.java

@@ -36,6 +36,8 @@ public class ReadOnlyBuildPipelineView extends BuildPipelineView {
      *            is trigger only latest job?
      * @param cssUrl
      *            URL for the custom CSS file.
+     * @param startsWithParameters
+     *            indicates if the first job in the view takes parameters
      */
     public ReadOnlyBuildPipelineView(final String displayName, final String description, final ProjectGridBuilder gridBuilder,
             final String noOfDisplayedBuilds, final boolean triggerOnlyLatestJob, final String cssUrl, final boolean startsWithParameters) {