Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup pom: compiler and encoding are managed via flags making maintenance easier and other plugins do use those flags too #1167

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

hazendaz
Copy link
Contributor

@hazendaz hazendaz commented Mar 4, 2024

No description provided.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.27%. Comparing base (3234238) to head (8e66077).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1167   +/-   ##
=========================================
  Coverage     98.27%   98.27%           
  Complexity      565      565           
=========================================
  Files            55       55           
  Lines          1214     1214           
  Branches        105      105           
=========================================
  Hits           1193     1193           
  Misses           10       10           
  Partials         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@damianszczepanik damianszczepanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I have similar issues in other projects

@damianszczepanik damianszczepanik merged commit da9e5e0 into damianszczepanik:master Mar 5, 2024
13 checks passed
@hazendaz hazendaz deleted the cleanup-pom branch May 29, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants