API cleanup

danReynolds · Sep 3, 2024 · b2460b6 · b2460b6
1 parent faebea2
commit b2460b6
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/lib/broadcast_manager.dart b/lib/broadcast_manager.dart
@@ -111,7 +111,7 @@ class BroadcastManager {
     }
 
     final pendingEvent = eventStore.get(path);
-    // Ignore writing a duplicate events or overwriting a pending mutative event type with a touched event.
+    // Ignore writing a duplicate event or overwriting a pending mutative event type with a touched event.
     if (pendingEvent == null ||
         (event != pendingEvent && event != BroadcastEvents.touched)) {
       eventStore.write(path, event);

diff --git a/lib/broadcast_observer.dart b/lib/broadcast_observer.dart
@@ -71,6 +71,8 @@ mixin BroadcastObserver<T, S> {
     return _changeController.stream;
   }
 
+  bool get isDirty;
+
   T? get _value {
     return Loon._instance.broadcastManager.observerValueStore.get(_observerId);
   }

diff --git a/lib/observable_document.dart b/lib/observable_document.dart
@@ -85,6 +85,9 @@ class ObservableDocument<T> extends Document<T>
     }
   }
 
+  @override
+  get isDirty => _value == null && super.get() != null;
+
   @override
   ObservableDocument<T> observe({
     bool multicast = false,
@@ -94,7 +97,7 @@ class ObservableDocument<T> extends Document<T>
 
   @override
   get() {
-    return _value ?? (_value = super.get());
+    return isDirty ? (_value = super.get()) : _value;
   }
 
   Map inspect() {

diff --git a/lib/observable_query.dart b/lib/observable_query.dart
@@ -268,9 +268,12 @@ class ObservableQuery<T> extends Query<T>
     return this;
   }
 
+  @override
+  get isDirty => _value == null;
+
   @override
   get() {
-    return _value ?? (_value = super.get());
+    return isDirty ? (_value = super.get()) : _value!;
   }
 
   Map inspect() {