Add -o ro to davfs mount command

dandi · Aug 23, 2024 · 8f0d215 · 8f0d215
1 parent b23f124
commit 8f0d215
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/WEBDAV.md b/WEBDAV.md
@@ -24,15 +24,15 @@ davfs2
   the following commands with `sudo` without entering a password:
 
     ```
-    mount -t davfs https://webdav.dandiarchive.org /mnt/backup/dandi/dandisets-healthstatus/dandisets-fuse
+    mount -t davfs -o ro https://webdav.dandiarchive.org /mnt/backup/dandi/dandisets-healthstatus/dandisets-fuse
     umount /mnt/backup/dandi/dandisets-healthstatus/dandisets-fuse
     ```
 
   This can be done by adding the following lines to `/etc/sudoers`, where
   `username` is replaced by the name of the user account:
 
     ```
-    username ALL=(ALL:ALL) NOPASSWD: /usr/bin/mount -t davfs https\://webdav.dandiarchive.org /mnt/backup/dandi/dandisets-healthstatus/dandisets-fuse
+    username ALL=(ALL:ALL) NOPASSWD: /usr/bin/mount -t davfs -o ro https\://webdav.dandiarchive.org /mnt/backup/dandi/dandisets-healthstatus/dandisets-fuse
     username ALL=(ALL:ALL) NOPASSWD: /usr/bin/umount /mnt/backup/dandi/dandisets-healthstatus/dandisets-fuse
     ```
 

diff --git a/code/src/healthstatus/mounts.py b/code/src/healthstatus/mounts.py
@@ -186,7 +186,16 @@ def mount(self) -> Iterator[None]:
         log.debug("Mounting davfs2 mount ...")
         self.mount_path.mkdir(parents=True, exist_ok=True)
         subprocess.run(
-            ["sudo", "mount", "-t", "davfs", DANDIDAV_URL, os.fspath(self.mount_path)],
+            [
+                "sudo",
+                "mount",
+                "-t",
+                "davfs",
+                "-o",
+                "ro",
+                DANDIDAV_URL,
+                os.fspath(self.mount_path),
+            ],
             check=True,
         )
         try: