Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Yubikey OTP Support #254

Merged
merged 9 commits into from
Nov 16, 2018
Merged

Adds Yubikey OTP Support #254

merged 9 commits into from
Nov 16, 2018

Conversation

Step7750
Copy link
Contributor

@Step7750 Step7750 commented Nov 16, 2018

Resolves #86
Feature Requests: #246

Features:

  • Yubikey OTP Support
  • Multiple keys (up to 5)
  • Custom OTP Validation server

Known Issues:

Requires pkg-config and libusb

Copy link
Owner

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I left a couple of comments that I'd like you to review.

About the libusb issue, the changes to the library were pretty simple so I made a fork for now: https://github.com/dani-garcia/yubico-rs.

I simply hid everything that required libusb under a feature flag, so you´ll need to change the Cargo.toml file:

yubico = { version = "0.4.0", default-features = false } 

...

[patch.crates-io]
yubico = { git = 'https://github.com/dani-garcia/yubico-rs' }

Hopefully if I get some time, I can make a proper PR upstream

src/api/core/two_factor.rs Outdated Show resolved Hide resolved
src/api/core/two_factor.rs Show resolved Hide resolved
@dani-garcia
Copy link
Owner

One last thing, how are the keys deleted? Does it use the endpoint receiving EnableYubikeyData and simply sets the keys to None? Or is there a separate endpoint that isn't implemented?

@Step7750
Copy link
Contributor Author

You can use the /two-factor/disable endpoint that gets called when you click "Disable All Keys" or you can remove all Yubikeys in the form and save.

@dani-garcia
Copy link
Owner

Right, then I think this is ready to be merged.

Thanks for all your work, @Step7750!

@dani-garcia dani-garcia merged commit c5c9e3f into dani-garcia:master Nov 16, 2018
@dani-garcia dani-garcia mentioned this pull request Dec 6, 2018
61 tasks
thelittlefireman pushed a commit to thelittlefireman/bitwarden_rs that referenced this pull request Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants