-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Yubikey OTP Support #254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, I left a couple of comments that I'd like you to review.
About the libusb issue, the changes to the library were pretty simple so I made a fork for now: https://github.com/dani-garcia/yubico-rs.
I simply hid everything that required libusb under a feature flag, so you´ll need to change the Cargo.toml file:
yubico = { version = "0.4.0", default-features = false }
...
[patch.crates-io]
yubico = { git = 'https://github.com/dani-garcia/yubico-rs' }
Hopefully if I get some time, I can make a proper PR upstream
One last thing, how are the keys deleted? Does it use the endpoint receiving |
You can use the |
Right, then I think this is ready to be merged. Thanks for all your work, @Step7750! |
Adds Yubikey OTP Support
Resolves #86
Feature Requests: #246
Features:
Known Issues:
Requires pkg-config and libusb