Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 11.x Compatibility #99

Closed

Conversation

laravel-shift
Copy link

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 11.x.

Before merging, you need to:

  • Checkout the l11-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/lighthouse-sanctum.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "daniel-de-wit/lighthouse-sanctum": "dev-l11-compatibility",
    }
}

Finally, run: composer update

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8121236181

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.63%

Totals Coverage Status
Change from base Build 4923888399: 0.0%
Covered Lines: 269
Relevant Lines: 270

💛 - Coveralls

@eshimischi
Copy link

Lighthouse PR is not migrated yet

@amharris
Copy link

amharris commented Apr 4, 2024

Lighthouse PR is not migrated yet

The above/referenced PR for Lighthouse to support Laravel 11 has now been merged.

From initial testing, running this dev branch with Laravel 11 seems to be okay, and no glaring issues have occurred so far. Probably safe to merge.

@ibrahem-kamal
Copy link

@daniel-de-wit any estimation on this PR ?

@daniel-de-wit
Copy link
Owner

@ibrahem-kamal @amharris Sorry for the delay, I was waiting for Lighthouse release indeed.

@amharris
Copy link

Thanks, @daniel-de-wit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants