parse syslog #501
Merged
parse syslog #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| }() | ||
| c := make(chan os.Signal, 1) | ||
| signal.Notify(c, os.Interrupt) | ||
| <-c | ||
| } | ||
|
|
||
| func rawSyslog(log string) string { |
There was a problem hiding this comment.
can you abye move this logic out of the main and to the syslog package?
If someone wants to use this from the API later or just as a module having it in main.go is kind of an antipattern.
And yes, I know I am guilty of this myself :-D
There was a problem hiding this comment.
i would not move the raw and legacy parser anywhere, raw doesn't do anything and the legacy json parser is pretty much useless ;) so offering the proper parser for reuse makes sense everything else should be hidden, could even be marked as deprecated. Let me know if that makes sense
There was a problem hiding this comment.
oh yeah. Now I see it. Thanks for explaining!
danielpaulus
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parse all fields from the syslog into dedicated json fields when passing
--parseso filtering gets easierstick to the legacy formats if nothing is passed or json disabled
the timestamp handling is really ugly as syslog doesn't provide the year 🤯 nor the timezone