Removed error log for iOS <17 trying to start tunnel #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joao-borges
force-pushed
the
remove_ios16_log_tunnel
branch
from
daf6b11 to
4ac5f03
Compare
|
@joao-borges can you split the PR in 2 please? i like both changes (there are a lot of things we should fix in docs) but handling them separately makes things just easier. |
joao-borges
force-pushed
the
remove_ios16_log_tunnel
branch
from
4ac5f03 to
1062a11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For an environment with mixed older iOS devices (v < 17) and newer ones (v >= 17) there is a persistent non stop log in the tunnel process that says tunnel was not created for iOS older version. This is a redundant information but to not lose the logging statement, I've moved it to a trace level and made the necessary changes to support that.