Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change noisy log line level from 'Info' to 'Debug' #549

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

buxomant
Copy link
Contributor

This log line generates a lot of content, most of which doesn't seem to be terribly useful under most circumstances, e.g.

2025-01-17 03:48:28.389990-0500 <PROCESS_NAME> Got parameterized attribute fetch for XC_kAXXCParameterizedAttributeConvertHostedViewFrame response with values {
Height = "62.33333460489908";
Width = 74;
X = 354;
Y = 143;
}, error: (null)

This doesn't seem to happen for iOS 17, I've only observed it for iOS 16 so far. My guess is that for iOS 17 we use a different method that doesn't have this excessive logging (and that was likely an intentional change).

I'm changing it to "Debug", as it might be useful under specific circumstances, but I don't think it should print everything all the time.

@dmissmann dmissmann merged commit eb39dd8 into danielpaulus:main Jan 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants