Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump langchain deps to address vulnerability warnings #4662

Closed
wants to merge 1 commit into from

Conversation

maxesse
Copy link
Contributor

@maxesse maxesse commented Nov 7, 2024

Pull Request Template

Summary

This PR updates langchain and its deps to the latest versions to fix a dependabot medium vulnerability that allows path traversal into an affected instance. Librechat is not directly affected by this issue, but it's always good to use new versions of dependencies when possible.

Change Type

Please delete any irrelevant options.

  • Bug fix (non-breaking change which fixes an issue)

Testing

I tested completions against base models, agents, assistants, etc. but not plugins, which I understand is where langchain is getting used - they are to be deprecated anyways.

Test Configuration:

I ran the api test suite and the results are the same as for the main branch.

Please delete any irrelevant options.

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • My changes do not introduce new warnings
  • Local unit tests pass with my changes

@maxesse
Copy link
Contributor Author

maxesse commented Nov 7, 2024

Looking at the failed test, the plugin ones fail as expected, while the tokenSplit one is due to a change of behaviour in langchain where periods now get kept together with the token rather than separated like the test expects. Not sure whether this is desired or not?

- Expected  - 1    (what the test expected)
+ Received  + 1    (what it actually got)

  Array [
+   "it.",         <-- RECEIVED: This chunk appeared in the result but wasn't expected
    ". Null",      <-- Both had this
    " Nullam",     <-- Both had this
    "am id",       <-- Both had this
    " id.",        <-- Both had this
-   ".",           <-- EXPECTED: Test expected a lone period at the end, but didn't get it
  ]

@danny-avila danny-avila changed the title chore: bump langchain deps to fix path traversal vulnerability chore: bump langchain deps to address vulnerability warnings Nov 7, 2024
@danny-avila
Copy link
Owner

replacing this here: #4707

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants