-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stylix: add testbeds for desktop environments #320
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Should we add a central testbed
package that runs all other testbed-${testbed.name}-${stylix.polarity}
packages? This would avoid a complicated nix flake show | <PARSING> | nix run
command and the following boilerplate test script:
nix run .#testbed-gnome-dark
nix run .#testbed-gnome-light
nix run .#testbed-kde-dark
nix run .#testbed-kde-light
The pkgs.buildEnv
function allows merging the outputs of a list of derivations.
For reference, I have used pkgs.buildEnv
for a similar use case at: https://github.com/trueNAHO/asciidoctor.nix/blob/8ed50e9bdeaede79753ff7656d82fbc12cddc191/flake.nix#L124-L127.
Alternatively, we could simply add the testbed-${testbed.name}-${stylix.polarity}
packages to the checks
output. This approach might be better than the nix run
approach.
This depends on #330 since it uses a file name with a space |
This allows usage with `nix run` without having to specify the current architecture.
These are meant for manual testing, since they open a virtual machine where you can mess around with the application and check the styling. Hence it's important to be able to run an individual testbed as easily as possible. Using the checks output, to run a testbed you would have to type (The testbeds are also built on GitHub Actions, but this is only to pick up on obvious build failures. It's still necessary to do a manual check to see whether anything changed visually.)
As mentioned above, running these opens a virtual machine, so it doesn't make sense to run a large number at once like that. |
|
Co-authored-by: NAHO <[email protected]>
Co-authored-by: NAHO <[email protected]>
First stage of #319.
This allows a NixOS configuration to be defined for any target by creating a file named
testbed.nix
in the target directory.For each
testbed.nix
, we generate two virtual machines:TODOs for this PR: