Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyprland: import hyprpaper module #701

Closed

Conversation

trueNAHO
Copy link
Collaborator

@trueNAHO trueNAHO commented Dec 27, 2024

Import the hyprpaper module to hopefully resolve #699.


Cc: @Lem0nbleach

@Lem0nbleach
Copy link

I am sorry for being a noob
what should the path be for me to pull this into my input?

@trueNAHO
Copy link
Collaborator Author

I am sorry for being a noob what should the path be for me to pull this into my input?

No worries:

inputs = {
  stylix.url = "github:trueNAHO/stylix/hyprland-importhyprpaper-module";
};

@trueNAHO
Copy link
Collaborator Author

the issue still occurs

-- Lem0nbleach, #699 (comment)

@danth, should we merge this PR for completeness, despite it not resolving #699?

Copy link
Owner

@danth danth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I right in thinking this is to protect against the case where a user adds the hyprpaper module to disabledModules, and therefore hyprland causes an error by using an undefined option?

If so, protecting against this seems unusual, as a user could break Stylix in lots of similar ways, by disabling the core modules for example.

Eveeifyeve added a commit to Eveeifyeve/Dotfiles that referenced this pull request Jan 21, 2025
I am doing this until pr ir out:
danth/stylix#701
@trueNAHO
Copy link
Collaborator Author

Am I right in thinking this is to protect against the case where a user adds the hyprpaper module to disabledModules, and therefore hyprland causes an error by using an undefined option?

If so, protecting against this seems unusual, as a user could break Stylix in lots of similar ways, by disabling the core modules for example.

True. I will close this PR since it probably has no effect anyways.

@trueNAHO trueNAHO closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot disable styling for Hyprland (Option not exist)
3 participants