-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flexible Qt theming with sensible defaults. #780
Open
Mikilio
wants to merge
11
commits into
danth:master
Choose a base branch
from
Mikilio:pr-142
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Local testing still in progress Performed a rebase let me know if you want a merge instead. |
Mikilio
force-pushed
the
pr-142
branch
4 times, most recently
from
January 18, 2025 18:46
b6d4e66
to
dd58e80
Compare
Mikilio
force-pushed
the
pr-142
branch
2 times, most recently
from
January 18, 2025 19:14
cf84325
to
28f4004
Compare
These changes make the PR apply the Kvatum theme only when appropriate and creates the framework to allow for Qt styling based on the DE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of PR #142. It includes some changes I've made in the past, but also my more recent and most important change that hopefully is a good step towards getting this merged. This PR should be carefully reviewed.