chore: public accessor fixes

danthorpe · Sep 17, 2024 · bf15d6e · bf15d6e
1 parent d21a0f5
commit bf15d6e
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 5 deletions.
diff --git a/Sources/ComposableLoadable/Loadable/LoadableClient.swift b/Sources/ComposableLoadable/Loadable/LoadableClient.swift
@@ -10,7 +10,9 @@ package protocol LoadableClient<Request, State, Value> {
   var load: @Sendable (Request, State) async throws -> Value { get }
 }
 
-public struct EmptyLoadRequest: Equatable {}
+public struct EmptyLoadRequest: Equatable {
+  public init() {}
+}
 
 struct LoadingClient<Request, State, Value>: LoadableClient {
   var load: @Sendable (Request, State) async throws -> Value

diff --git a/Sources/ComposableLoadable/Loadable/LoadableState.swift b/Sources/ComposableLoadable/Loadable/LoadableState.swift
@@ -239,11 +239,11 @@ extension LoadableState where Request == EmptyLoadRequest {
     self.init(request: EmptyLoadRequest(), failure: error)
   }
 
-  mutating func becomeActive() {
+  mutating public func becomeActive() {
     becomeActive(EmptyLoadRequest())
   }
 
-  mutating func finish(
+  mutating public func finish(
     _ result: Result<Value, Error>
   ) {
     finish(EmptyLoadRequest(), result: result)

diff --git a/Sources/ComposableLoadable/Loadable/LoadingAction.swift b/Sources/ComposableLoadable/Loadable/LoadingAction.swift
@@ -22,7 +22,9 @@ extension LoadingAction where Request == EmptyLoadRequest {
 
 // MARK: - Conformances
 
-extension LoadingAction: Equatable where Value: Equatable {}
+extension LoadingAction: Equatable where Value: Equatable {
+  // NOTE: Define conformance here, but implementation is below
+}
 
 extension LoadingAction where Request: Equatable, Value: Equatable, Action: Equatable {
   public static func == (lhs: Self, rhs: Self) -> Bool {

diff --git a/Sources/ComposableLoadable/Pagination/PaginationFeature+.swift b/Sources/ComposableLoadable/Pagination/PaginationFeature+.swift
@@ -48,3 +48,9 @@ extension PaginationFeature.Action: Equatable where Element: Equatable {
     }
   }
 }
+
+extension PaginationFeature: Equatable where Element: Equatable {
+  public static func == (lhs: Self, rhs: Self) -> Bool {
+    true  // There is only behaviour in the reducer itself.
+  }
+}
diff --git a/Sources/ComposableLoadable/Pagination/PaginationFeature.swift b/Sources/ComposableLoadable/Pagination/PaginationFeature.swift
@@ -179,7 +179,6 @@ import Foundation
 
   public typealias Page = State.Page
   public typealias PageRequest = State.PageRequest
-
   public typealias LoadPage = @Sendable (PageRequest) async throws -> Page
 
   public var body: some ReducerOf<Self> {