-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-16686 dfuse: check the end offset for concurrent fetch #15719
Merged
Merged
Changes from 6 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d1dbe4b
DAOS-16686 dfuse: check the end offset for concurrent fetch
wangdi1 256c3cf
Update src/client/dfuse/ops/read.c
jolivier23 44550bc
Test flags
jolivier23 b665230
DAOS-16686 dfuse: pick the right eqt for pre-read
wangdi1 72cb36a
DAOS-16686 tests: remvoe pre-read counter
wangdi1 3b7ca05
DAOS-16686 dfuse: fix copyright
wangdi1 09dea61
Merge branch 'google/2.6' into wangdi/google_dfuse_fix
jolivier23 d1125d9
Update utils/node_local_test.py
jolivier23 b65217c
Allow-unstable-test: true
jolivier23 973fc51
DAOS-16686 dfuse: revert page-size alignment inflight check.
wangdi1 0b15886
DAOS-16686 tests: remove pre-read check
wangdi1 95a1dd6
DAOS-16686 dfuse: disable the pre-read check for now
wangdi1 172af4a
DAOS-16686 dfuse: disable the pre-read check for now
wangdi1 6341cba
Merge remote-tracking branch 'refs/remotes/origin/wangdi/google_dfuse…
wangdi1 f500d31
Merge branch 'google_2.6' into wangdi/google_dfuse_fix
wangdi1 9615c15
Update read.py
jolivier23 f24bc18
Merge branch 'google/2.6' into wangdi/google_dfuse_fix
jolivier23 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,7 +1,9 @@ | ||||||
#!/usr/bin/env python3 | ||||||
"""Node local test (NLT). | ||||||
|
||||||
(C) Copyright 2020-2024 Intel Corporation. | ||||||
(C) Copyright 2020-2025 Intel Corporation. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
(C) Copyright 2025 Google LLC | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
jolivier23 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
|
||||||
|
||||||
SPDX-License-Identifier: BSD-2-Clause-Patent | ||||||
|
||||||
|
@@ -2377,8 +2379,6 @@ def test_pre_read(self): | |||||
# Open a MB file. This reads 8 128k chunks and 1 EOF. | ||||||
with open(join(dfuse.dir, 'file3'), 'r') as fd: | ||||||
data3 = fd.read() | ||||||
res = dfuse.check_usage(old=res) | ||||||
assert res['statistics']['pre_read'] == 9, res | ||||||
|
||||||
# Open a (1MB-1) file. This reads 8 128k chunks, the last is truncated. There is no EOF | ||||||
# returned by dfuse here, just a truncated read but I assume python is interpreting a | ||||||
|
@@ -2387,14 +2387,9 @@ def test_pre_read(self): | |||||
data4 = fd.read() | ||||||
data5 = fd.read() | ||||||
|
||||||
res = dfuse.check_usage(old=res) | ||||||
assert res['statistics']['pre_read'] == 8, res | ||||||
|
||||||
# This should now be read from cache. | ||||||
with open(join(dfuse.dir, 'file4'), 'r') as fd: | ||||||
data6 = fd.read() | ||||||
res = dfuse.check_usage(old=res) | ||||||
assert res['statistics']['read'] == 0, res | ||||||
|
||||||
if dfuse.stop(): | ||||||
self.fatal_errors = True | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you restock elsewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
restock is actually not needed in this path, since no RPC is issued, so no buffer needed.