Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16971 cart: add origin address to RPC debug log #15825

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

DAOS-16971 cart: add origin address to RPC debug log #15825

wants to merge 6 commits into from
+111 −35

Conversation

wangdi1
Copy link
Contributor

@wangdi1 wangdi1 commented Jan 31, 2025

Add origin address to RPC debug log.

Run-GHA: true
Allow-unstable-test: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@wangdi1
DAOS-16971 cart: add origin address to RPC debug log
64adbc4 
Add origin address to RPC debug log.

Run-GHA: true
Allow-unstable-test: true
Signed-off-by: Di Wang <[email protected]>
@wangdi1 wangdi1 requested review from a team as code owners January 31, 2025 21:29
@github-actions GitHub Actions
Copy link

Ticket title is 'bulk cancel causing libfabric progress failure.'
Status is 'Awaiting Verification'
Labels: 'GCP,google-cloud-daos'
https://daosio.atlassian.net/browse/DAOS-16971

@wangdi1
DAOS-16971 cart: fix mem leak
f7bf078 
fix mem leak

Signed-off-by: Di Wang <[email protected]>
@wangdi1
DAOS-16971 object: revert some message
a5a5437 
Revert some log changes to please CI

Signed-off-by: Di Wang <[email protected]>
@wangdi1
DAOS-16971 cart: fix style
c9b8edd 
fix style

Signed-off-by: Di Wang <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15825/4/testReport/

jolivier23
jolivier23 previously approved these changes Feb 3, 2025
View reviewed changes
soumagne
soumagne previously approved these changes Feb 4, 2025
View reviewed changes
@wangdi1 wangdi1 dismissed stale reviews from soumagne and jolivier23 via 96e2eca February 6, 2025 02:12
@liuxuezhao liuxuezhao requested review from liuxuezhao and removed request for liuxuezhao February 6, 2025 09:53
jolivier23
jolivier23 reviewed Feb 6, 2025
View reviewed changes
src/cart/crt_hg.c
if (rc != 0)
return "NONE";

D_ALLOC(rpc_priv->crp_orig_uri, addr_size);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know our rpc handling is single threaded for the most part but is there a chance this could race in some cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolivier23 jolivier23 jolivier23 approved these changes

@frostedcmos frostedcmos frostedcmos approved these changes

@soumagne soumagne soumagne left review comments

@johannlombardi johannlombardi Awaiting requested review from johannlombardi

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wangdi1 @daosbuild1 @soumagne @jolivier23 @frostedcmos