Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16978 vos: fix issue in VOS pool recreation on faulty device rep… #15851

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

junzeng1
Copy link
Collaborator

@junzeng1 junzeng1 commented Feb 6, 2025

…lacing

Add a flag to identify the recreate operation in vos pool creation, and pass it to bio/smd module to avoid setting the SMD_POOL_IN_CREATION flag for recreation case in nvme disk replacing operation.

Run-GHA: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

…lacing

Add a flag to identify the recreate operation in vos pool creation, and pass it to
bio/smd module to avoid setting the SMD_POOL_IN_CREATION flag for recreation case in
nvme disk replacing operation.

Run-GHA: true
Signed-off-by: Jun Zeng <[email protected]>
@junzeng1 junzeng1 requested review from a team as code owners February 6, 2025 03:08
Copy link

github-actions bot commented Feb 6, 2025

Ticket title is 'pool shard been deleted abnormally when daos service restart after doing nvme disk replace'
Status is 'In Review'
Labels: 'md_on_ssd'
https://daosio.atlassian.net/browse/DAOS-16978

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15851/1/testReport/

Copy link

github-actions bot commented Feb 6, 2025

Functional on EL 8.8 Test Results

131 tests   127 ✅  1h 31m 19s ⏱️
 41 suites    4 💤
 41 files      0 ❌

Results for commit c942e8c.

♻️ This comment has been updated with latest results.

NiuYawei
NiuYawei previously approved these changes Feb 8, 2025
wangshilong
wangshilong previously approved these changes Feb 8, 2025
Allow-unstable-test: true
Run-GHA: true
Signed-off-by: Jun Zeng <[email protected]>
sherintg
sherintg previously approved these changes Feb 10, 2025
Run-GHA: true
Allow-unstable-test: true
Signed-off-by: Jun Zeng <[email protected]>
@junzeng1 junzeng1 dismissed stale reviews from sherintg, wangshilong, and NiuYawei via c942e8c February 11, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants