Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16876 vos: remove DTX record after partial commit - b26 #15858

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

Nasf-Fan
Copy link
Contributor

@Nasf-Fan Nasf-Fan commented Feb 7, 2025

Otherwise, the partial committed DTX entry will be re-committed when reopen the container. Then access related dangling DTX record(s) may trigger assertion and cause corruption.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Copy link

github-actions bot commented Feb 7, 2025

Ticket title is 'LRZ: m02r01s07dao engine coredumps with vos EMRG src/vos/ilog.c:411 ilog_open() Assertion'
Status is 'In Progress'
Labels: 'LRZ,google-cloud-daos'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16876

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Feb 7, 2025
@Nasf-Fan Nasf-Fan added the release-2.6.3 Targeted for 2.6.3 label Feb 7, 2025
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16876_2_b26 branch from b16c751 to f8bccd8 Compare February 7, 2025 06:45
@daosbuild1
Copy link
Collaborator

Test stage Unit Test with memcheck on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15858/4/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Unit Test bdev with memcheck on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15858/4/testReport/

gnailzenh
gnailzenh previously approved these changes Feb 7, 2025
@Nasf-Fan Nasf-Fan changed the title DAOS-16876 vos: remove DTX record after partial commit DAOS-16876 vos: remove DTX record after partial commit - b26 Feb 7, 2025
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16876_2_b26 branch from f8bccd8 to 4841c63 Compare February 7, 2025 13:26
@Nasf-Fan Nasf-Fan requested a review from gnailzenh February 7, 2025 14:42
jolivier23
jolivier23 previously approved these changes Feb 7, 2025
NiuYawei
NiuYawei previously approved these changes Feb 8, 2025
@Nasf-Fan Nasf-Fan dismissed stale reviews from NiuYawei and jolivier23 via 4bfb2e9 February 8, 2025 04:06
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16876_2_b26 branch from 4841c63 to 4bfb2e9 Compare February 8, 2025 04:06
Otherwise, the partial committed DTX entry will be re-committed when
reopen the container. Then access related dangling DTX record(s) may
trigger assertion and cause corruption.

Signed-off-by: Fan Yong <[email protected]>
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16876_2_b26 branch from 4bfb2e9 to 1bf9087 Compare February 8, 2025 04:30
@mchaarawi mchaarawi marked this pull request as ready for review February 10, 2025 21:07
@mchaarawi mchaarawi requested review from a team as code owners February 10, 2025 21:07
@mchaarawi mchaarawi requested a review from a team February 10, 2025 21:07
@mchaarawi mchaarawi merged commit 15912c1 into release/2.6 Feb 10, 2025
56 of 57 checks passed
@mchaarawi mchaarawi deleted the Nasf-Fan/DAOS-16876_2_b26 branch February 10, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority Ticket has high priority (automatically managed) release-2.6.3 Targeted for 2.6.3
Development

Successfully merging this pull request may close these issues.

7 participants