Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRE-2832 Build: Update for larger Jenkinsfiles #15935

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SRE-2832 Build: Update for larger Jenkinsfiles #15935

wants to merge 1 commit into from

Conversation

JohnMalmberg
Copy link
Contributor

Upate Jenkinsfiles to support SCRIPT_SPLITTING_TRANSFORMATION per https://issues.jenkins.io/browse/JENKINS-56500

utils/githooks/README.md: Fix markuplint flagged issues.

utils/scripts/helpers/install_maldet.ch : Fix defaults to be more neutral.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@JohnMalmberg JohnMalmberg requested review from a team as code owners February 18, 2025 21:27
@github-actions GitHub Actions
Copy link

Errors are Component should be lower-case,Unable to load ticket data
https://daosio.atlassian.net/browse/SRE-2832

@JohnMalmberg JohnMalmberg force-pushed the malmberg/sre-2832 branch 7 times, most recently from 66df644 to de8746d Compare February 20, 2025 22:53
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 20, 2025
View reviewed changes
utils/docker/Dockerfile.code_scanning
# Pull base image
FROM fedora:latest
ARG FVERSION=latest
FROM fedora:$FVERSION

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: containerImage not pinned by hash
Click Remediation section below to solve this issue
@JohnMalmberg JohnMalmberg force-pushed the malmberg/sre-2832 branch 7 times, most recently from b9014b1 to 8bd07dd Compare February 21, 2025 00:19
@JohnMalmberg
SRE-2832 Build: Update for larger Jenkinsfiles
406b81e 
Update Jenkinsfiles to support SCRIPT_SPLITTING_TRANSFORMATION per
https://issues.jenkins.io/browse/JENKINS-56500

utils/githooks/README.md: Fix markuplint flagged issues.

utils/scripts/helpers/install_maldet.ch :
  Fix defaults to be more implementation neutral.

utils/scripts/helpers/repo-helper-*.sh :
  Optionally install CA needed to validate local repository mirrors.

Dockerfiles modified to support intalling the CA.

Dockerfile.code_scanning modified to allow specifying the fedora
version used.

Signed-off-by: John E. Malmberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JohnMalmberg