aws auth: add missing auth methods #3597
Open
+133
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sicoyle
reviewed
Nov 12, 2024
| return awsRegion, awsAccessKey, awsSecretKey, nil | ||
| awsSessionToken, _ := metadata.GetMetadataProperty(m.awsEnv.Metadata, "AWSSessionToken") | ||
|
|
||
| awsIamRoleArn, _ := metadata.GetMetadataProperty(m.awsEnv.Metadata, "awsIamRoleArn") |
There was a problem hiding this comment.
Suggested change
| awsIamRoleArn, _ := metadata.GetMetadataProperty(m.awsEnv.Metadata, "awsIamRoleArn") | |
| assumeRoleArn, _ := metadata.GetMetadataProperty(m.awsEnv.Metadata, "assumeRoleArn") |
There was a problem hiding this comment.
this cannot be changed, it must match with metadata.yaml , metadata.yaml has been set to match the existing metadata names for the kafka component, so we have consistency
| awsSessionToken, _ := metadata.GetMetadataProperty(m.awsEnv.Metadata, "AWSSessionToken") | ||
|
|
||
| awsIamRoleArn, _ := metadata.GetMetadataProperty(m.awsEnv.Metadata, "awsIamRoleArn") | ||
| awsStsSessionName, _ := metadata.GetMetadataProperty(m.awsEnv.Metadata, "awsStsSessionName") |
There was a problem hiding this comment.
Suggested change
| awsStsSessionName, _ := metadata.GetMetadataProperty(m.awsEnv.Metadata, "awsStsSessionName") | |
| sessionName, _ := metadata.GetMetadataProperty(m.awsEnv.Metadata, "sessionName") |
I don't think we need to expose to end users the underlying mechanisms leveraging Sts through which one can assume a new role with new creds
There was a problem hiding this comment.
this cannot be changed, it must match with metadata.yaml , metadata.yaml has been set to match the existing metadata names for the kafka component, so we have consistency
famarting
commented
Nov 13, 2024
common/authentication/aws/aws.go
Outdated
| @@ -118,40 +119,66 @@ type AWSIAMAuthOptions struct { | |||
| Region string `json:"region" mapstructure:"region"` | |||
| AccessKey string `json:"accessKey" mapstructure:"accessKey"` | |||
| SecretKey string `json:"secretKey" mapstructure:"secretKey"` | |||
| SessionToken string `json:"sessionToken" mapstructure:"sessionToken"` | |||
|
|
|||
| AssumeRoleArn string `json:"assumeRoleArn" mapstructure:"assumeRoleArn"` | |||
There was a problem hiding this comment.
agreed to change this fields tags, but they are not used for anything
famarting
force-pushed
the
add-missing-aws-auth-methods
branch
from
652e3dc
to
c7848a3
Compare
Signed-off-by: Fabian Martinez <[email protected]>
famarting
force-pushed
the
add-missing-aws-auth-methods
branch
from
f455abe
to
2a8e733
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing AWS IAM auth with postgres and missing the assume role feature that its documented as part of the aws auth profile
It all started because this error check here is bad https://github.com/dapr/components-contrib/blob/main/common/authentication/aws/aws.go#L133
if there is no error,
errors.Is(err, config.SharedConfigAssumeRoleError{}.Err)always evaluates to true... because when you doconfig.SharedConfigAssumeRoleError{}.ErrthenErris nil!I started fixing that but then looking at the kafka pubsub component https://github.com/dapr/components-contrib/blob/main/common/component/kafka/auth.go#L99 , kafka supports more fields, so it made sense to also support these for postgres.
docs updated here dapr/docs#4429
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: