add missing JsonPropertyName to Data property #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NenadSteric
force-pushed
the
fix_JsonSerialization
branch
from
ba39d72
to
ca3787b
Compare
NenadSteric
changed the title
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1000 +/- ##
=======================================
Coverage 66.42% 66.42%
=======================================
Files 171 171
Lines 5758 5758
Branches 626 626
=======================================
Hits 3825 3825
Misses 1784 1784
Partials 149 149
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
@approvers-dotnet-sdk: anything else needed ? |
NenadSteric
force-pushed
the
fix_JsonSerialization
branch
from
ca3787b
to
cc1e276
Compare
NenadSteric
force-pushed
the
fix_JsonSerialization
branch
2 times, most recently
from
008e7df
to
92ad699
Compare
…o force the JsonSerializer to use camelCase with JsonSerializerOptions Signed-off-by: Nenad Steric <[email protected]> Signed-off-by: Nenad Steric <[email protected]>
|
@philliphoff Should we announce this as an upcoming breaking change in the 1.15 release notes and then release with 1.16? Anyone that has been overriding the JsonSerializationOptions with any rules for the names would have their own values here whereas this change would fix the value to "data" regardless of those rules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without it you need to force the JsonSerializer to use camelCase with JsonSerializerOptions
Description
adds JsonPropertyName to make the casing consistent with the other properties.
This also makes it possible to use just Serialize without JsonSerializerOptions
as the pubsub json handling code in Dapr needs this property to be lowercase.
This problem had to be fixed during testing of the new Bulk-publish API
where I needed to serialize the CloudEvent classes manually without the DaprClient.
Issue reference
as discussed in
#976 and #944
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Please comment if any new tests or documentation needs to be created.