Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registering actor from Type in runtime #1091

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nero-philip-wang
Copy link

@nero-philip-wang nero-philip-wang commented May 18, 2023

Signed-off-by: Nero Wang [email protected]

Description

If some actor types are found by reflection in runtime, it cannot be registered. So I add registering actor from Type but not only GenericType so that we can register actor as following.

Type actorType = provider.GetService<ISomeActorType>();
actorRegistrationCollection.RegisterActor(actorType, null, null);

Issue reference

Please reference the issue this PR will close: #202

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@nero-philip-wang nero-philip-wang requested review from a team as code owners May 18, 2023 09:21
@nero-philip-wang
Copy link
Author

nero-philip-wang commented May 18, 2023

Sorry for pull #259 . Besides, where should I extended the documentation if the documentation is needed.

@nero-philip-wang nero-philip-wang marked this pull request as draft June 7, 2023 09:32
@halspang
Copy link
Contributor

@nero-philip-wang - Is this ready for review or is it still in draft?

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10ef818) 66.53% compared to head (a1ca303) 66.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1091      +/-   ##
==========================================
+ Coverage   66.53%   66.55%   +0.02%     
==========================================
  Files         171      171              
  Lines        5752     5756       +4     
  Branches      626      627       +1     
==========================================
+ Hits         3827     3831       +4     
  Misses       1776     1776              
  Partials      149      149              
Flag Coverage Δ
net6 66.54% <100.00%> (+0.02%) ⬆️
net7 66.54% <100.00%> (+0.02%) ⬆️
net8 66.54% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add registering actor from Type but not only GenericType
2 participants