Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs to register actor endpoint via top-level registrations #1262

Merged

Conversation

WhitWaldo
Copy link
Contributor

Description

With the release of .NET 8, a warning for ASP0014 was added that suggests that routes shouldn't be registered via app.UseEndpoints and longer and should rather be registered directly from the built web application.

This requires no changes to the SDK itself, but the documentation should be updated to reflect the change and this PR corrects this as was pointed out by the issue in #1256.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1256

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly (not applicable, no code changes made)
  • Created/updated tests (not applicable, no code changes made)
  • Extended the documentation

@WhitWaldo WhitWaldo requested review from a team as code owners April 3, 2024 08:44
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.28%. Comparing base (1b7c9f4) to head (885a641).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1262   +/-   ##
=======================================
  Coverage   67.28%   67.28%           
=======================================
  Files         174      174           
  Lines        6025     6025           
  Branches      671      671           
=======================================
  Hits         4054     4054           
  Misses       1802     1802           
  Partials      169      169           
Flag Coverage Δ
net6 67.26% <ø> (ø)
net7 67.26% <ø> (ø)
net8 67.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philliphoff philliphoff merged commit 31af35b into dapr:master Apr 8, 2024
12 checks passed
@WhitWaldo WhitWaldo deleted the top-level-aspnet-endpoint-registration branch April 8, 2024 23:19
@philliphoff philliphoff added this to the v1.14 milestone Jul 23, 2024
divzi-p pushed a commit to divzi-p/dotnet-sdk that referenced this pull request Dec 10, 2024
…l route registrations (dapr#1262)

Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Divya Perumal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dapr Actor startup in AspNetCore - Issue in .NET 8
2 participants