Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added workflow sample: Async operations #1394

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

WhitWaldo
Copy link
Contributor

@WhitWaldo WhitWaldo commented Oct 30, 2024

Description

Added workflow sample demonstrating async operation with a polling mechanism to get the current status of an in-progress workflow.

Replaces #1393 because of a DCO commit failure I can't seem to get rid of in the PR itself.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1203

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly

@WhitWaldo WhitWaldo added this to the v1.15 milestone Oct 30, 2024
@WhitWaldo WhitWaldo self-assigned this Oct 30, 2024
@WhitWaldo WhitWaldo requested review from a team as code owners October 30, 2024 20:17
@WhitWaldo WhitWaldo changed the title Added async operations workflow sample Added workflow sample: Async operations Nov 1, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.04%. Comparing base (1b7c9f4) to head (957076d).
Report is 64 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1394      +/-   ##
==========================================
+ Coverage   67.28%   71.04%   +3.75%     
==========================================
  Files         174      188      +14     
  Lines        6025     6386     +361     
  Branches      671      697      +26     
==========================================
+ Hits         4054     4537     +483     
+ Misses       1802     1684     -118     
+ Partials      169      165       -4     
Flag Coverage Δ
net6 ?
net7 ?
net8 71.04% <ø> (+3.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

philliphoff
philliphoff previously approved these changes Nov 12, 2024
Copy link
Collaborator

@philliphoff philliphoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Collaborator

@philliphoff philliphoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: !!!

@WhitWaldo WhitWaldo merged commit 74a9811 into dapr:master Nov 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more workflow samples
2 participants