Bugfix: Crypto ReadOnlyMemory<byte> decryption times out #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y byte arrays properly (doesn't impact stream encryption/decryption). Signed-off-by: Whit Waldo <[email protected]>
…mance project handles the creation of MemoryStreams without an allocation. Restored the use of MemoryMarshal, but throws an exception if the data cannot be accessed now, instead of hanging as it did in a previous iteration. Tested both paths (string and stream) from example project successfully. Signed-off-by: Whit Waldo <[email protected]>
philliphoff
reviewed
Jan 15, 2025
philliphoff
reviewed
Jan 15, 2025
philliphoff
previously approved these changes
Jan 15, 2025
Signed-off-by: Whit Waldo <[email protected]>
philliphoff
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While updating the Crypto example in preparation for creating a Quickstart, I realized that the
DecryptAsyncoverload that accepted aReadOnlyMemory<byte>timed out whenever it was used. I suspected the issue is related to theMemoryMarshal, which was being used to avoid an allocation. But reviewing the implementation, I realized that we were still getting that allocation later on when we created a newMemoryStreamfrom theMemoryMarshaloutput.I've instead opted to create a
MemoryStream, write the input to it and reset the position to 0 to use in theEncryptAsyncandDecryptAsyncoperations.After making this change, both examples have been tested to work as expected (both stream and byte-based).
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: