Skip to content

Commit

Permalink
fix(darekf77/tnp#21): typo migration isReadyToRun
Browse files Browse the repository at this point in the history
  • Loading branch information
darekf77 committed Dec 31, 2024
1 parent eff69fe commit a394a94
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 13 deletions.
4 changes: 1 addition & 3 deletions .vscode/extensions.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,6 @@
"tomoki1207.pdf",
"hediet.vscode-drawio",
"christian-kohler.path-intellisense",
"thebearingedge.vscode-sql-lit",
"ms-vscode-remote.remote-wsl",
"kgrzywocz.wsl-path"
"thebearingedge.vscode-sql-lit"
]
}
1 change: 1 addition & 0 deletions TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
- 🔲 simple CD/CI develop/build/deploy process
- 🔲 local release electron, cli, vscode ext.
- 🔲 script installation for server (curl -o- https://taon.dev/install-on-server-script.sh | bash)
- 🔲 release standalone package as @organization/package

## Taon (Firedev) v17.X.X

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,6 @@
"tomoki1207.pdf",
"hediet.vscode-drawio",
"christian-kohler.path-intellisense",
"thebearingedge.vscode-sql-lit",
"ms-vscode-remote.remote-wsl",
"kgrzywocz.wsl-path"
"thebearingedge.vscode-sql-lit"
]
}
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"projects": []
}
{
"projects": []
}
2 changes: 1 addition & 1 deletion src/lib/base-classes/base-migration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export class BaseMigration extends BaseInjector implements MigrationInterface {
/**
* by default is READY to run
*/
public isReadToRun(): boolean {
public isReadyToRun(): boolean {
return true;
}

Expand Down
6 changes: 3 additions & 3 deletions src/lib/context-db-migrations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ export class ContextDbMigrations {
})
.filter(f => !!f)
.map(f => f as BaseMigration)
.filter(migrationInstance => migrationInstance.isReadToRun());
.filter(migrationInstance => migrationInstance.isReadyToRun());

const queryRunner = this.ctx.connection.createQueryRunner();
await queryRunner.connect();
Expand Down Expand Up @@ -273,7 +273,7 @@ export class ContextDbMigrations {
const migrationClassesInstances: BaseMigration[] = migrationsClassFns
.map(classFn => this.ctx.getInstanceBy(classFn as any))
.map(f => f as BaseMigration)
.filter(migrationInstance => migrationInstance.isReadToRun());
.filter(migrationInstance => migrationInstance.isReadyToRun());

const queryRunner = this.ctx.connection.createQueryRunner();
await queryRunner.connect();
Expand Down Expand Up @@ -350,7 +350,7 @@ export class ContextDbMigrations {
const migrationClassesInstances: BaseMigration[] = migrationsClassFns
.map(classFn => this.ctx.getInstanceBy(classFn as any))
.map(f => f as BaseMigration)
.filter(migrationInstance => migrationInstance.isReadToRun());
.filter(migrationInstance => migrationInstance.isReadyToRun());

const queryRunner = this.ctx.connection.createQueryRunner();
await queryRunner.connect();
Expand Down

0 comments on commit a394a94

Please sign in to comment.