Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Removed unused variable on logcore.py. " #2

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

dd84ai
Copy link
Member

@dd84ai dd84ai commented Mar 29, 2024

Reverts #1

Actually no, we should not delete it because... some app already uses this alias as a shortcut to this and i don't wish to break it.

@dd84ai dd84ai merged commit 830cecb into master Mar 29, 2024
2 checks passed
@dd84ai dd84ai deleted the revert-1-master branch March 29, 2024 10:56
@Abdujabbar
Copy link

Hm, maybe better to extract this like of code into a separated module, for example, shortcuts.py, just a suggestion.

@dd84ai
Copy link
Member Author

dd84ai commented Mar 29, 2024

@Abdujabbar we could but it would still break some depended code i don't wish to break 😅
What can be a usage case to remove or move it?
This is just an alias that is not affecting performance of the library in any way ^_^.
As a class Type, nothing is initialized, so it is not really "a variable", it is just an alias to a type of a variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants