Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "no-samples" for GoPro FUSION #713

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

kmilos
Copy link
Contributor

@kmilos kmilos commented Apr 22, 2024

Samples now provided in darktable-org/darktable#16646

@kmilos kmilos requested a review from LebedevRI as a code owner April 22, 2024 09:37
@kmilos kmilos changed the title Remove no samples for GoPro FUSION Remove "no-samples" for GoPro FUSION Apr 22, 2024
@kmilos
Copy link
Contributor Author

kmilos commented Apr 22, 2024

In fact, we could potentially remove all GoPro entries for a slimmer cameras.xml? They don't really do anything (like make/model normalization), and these are just like ordinary/generic DNGs... E.g., we didn't bother adding new ones after HERO8 anyway.

@LebedevRI LebedevRI merged commit b9db964 into darktable-org:develop Apr 22, 2024
55 of 56 checks passed
@LebedevRI
Copy link
Member

@kmilos thank you!

Yeah, i do not know. We could, but then it's not like it represents a significant chunk of the file.

@kmilos
Copy link
Contributor Author

kmilos commented Apr 22, 2024

Yep, just a thought... Never mind since this is now merged.

@kmilos kmilos deleted the patch-1 branch April 22, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants