Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added installation wiki file with more info and added screenshots #4

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

VitorFrost
Copy link

added installation wiki file with more info and added screenshots

Create the translation for Brazilian Portuguese.
added a link to installation page
added screenshots to the readme
create detailed installation instruction wiki page
Copy link
Owner

@darkxst darkxst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working in this, a couple of comments below

wget "$download_url"
filename="${download_url##*/}"
tar -xf "$filename"
```
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is bit complex to drop on the end user, can you wrap it up in a shell script and put in root of repo.

This way the user could just copy and run a single command to install

wget <repo>/install.sh | sh install.sh

Maybe also just include the installation within the main README

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to take translations, but please make that a seperate PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I started doing the translation and forgot about it! It wasn't my intention to include the translation yet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants