-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a basic benchmark for DeepCollectionEquality #717
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthBreaking changes ✔️
Coverage
|
File | Coverage |
---|---|
pkgs/collection/benchmark/deep_collection_equality.dart | 💔 Not covered |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check
.
API leaks ✔️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
Package | Leaked API symbols |
---|
License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files |
---|
no missing headers |
All source files should start with a license header.
Revisions updated by `dart tools/rev_sdk_deps.dart`. core (https://github.com/dart-lang/core/compare/4b62792..1156cfe): 1156cfe4 2024-11-06 Jacob MacDonald Use `values` iterator and `update` in map equality/hash (dart-lang/core#718) 9ab5a189 2024-11-05 Jacob MacDonald add a basic benchmark for DeepCollectionEquality (dart-lang/core#717) 9e379158 2024-11-05 Jonas Finnemann Jensen Introduce `IterableMapEntryExtension` for use with `Map.entries`. (dart-lang/core#715) dartdoc (https://github.com/dart-lang/dartdoc/compare/5168f81..24c2a96): 24c2a966 2024-11-04 dependabot[bot] Bump the github-actions group across 1 directory with 4 updates (dart-lang/dartdoc#3922) http (https://github.com/dart-lang/http/compare/8db0d0a..03ced4d): 03ced4d 2024-11-06 Brian Quinlan Upgrade flutter_http_example to cupertino_http (dart-lang/http#1393) df59bac 2024-11-05 Brian Quinlan Release package:cupertino_http 2.0.1 (dart-lang/http#1400) 0544e1f 2024-11-05 Brian Quinlan Fix a bug where cupertino_http did not work on iOS<17. (dart-lang/http#1399) sse (https://github.com/dart-lang/sse/compare/1b02011..befbd6d): befbd6d 2024-11-04 dependabot[bot] Bump actions/checkout from 4.2.0 to 4.2.2 in the github-actions group (dart-archive/sse#118) Change-Id: I2b4ebfe2f56f9478c7e89cd2d3e50485ae44caa0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393943 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Devon Carew <[email protected]> Auto-Submit: Devon Carew <[email protected]>
I wanted to check the performance impact of using
.entries
instead of.keys
followed by a lookup, so I wrote this.Will send out that PR separately - spoiler alert we might not want to land it 🤣 .