feat: support web in package:platform #862
Draft
+58
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
platform
provides a mockable interface for dart:io platform. I've suggested to the team that we use it to replace our custom implemention of the same concept with this package.However, I've failed to notice that pub.dev/packages/platform does not support web.
My suggestion is to add this, even if it's just with the information that can be gather with what is available on web.
Note: I have not actually researched and implemented any of the specific getters, just wanted to verify that it would make sense and wanted to show how it could look like in the code, with the conditional export.
If maintainers are open to introducing dart2js & dart2wasm support, I could update the code in
local_platform_web.dart
and add testsContribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.