Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jnigen] factory can be used as a method name without renaming #2044

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[jnigen] factory can be used as a method name without renaming #2044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkgs/jnigen/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.14.2-wip

- The name `factory` can now also be used in a method name without renaming.

## 0.14.1

- Added support for generating matching Kotlin operators as Dart operators.
Expand Down
2 changes: 1 addition & 1 deletion pkgs/jnigen/lib/src/bindings/renamer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const _keywords = {
'extends': _Allowed.none,
'extension': _Allowed.fields | _Allowed.methods,
'external': _Allowed.fields | _Allowed.methods,
'factory': _Allowed.fields | _Allowed.fields,
'factory': _Allowed.fields | _Allowed.methods,
'false': _Allowed.none,
'final': _Allowed.none,
'finally': _Allowed.none,
Expand Down
2 changes: 1 addition & 1 deletion pkgs/jnigen/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

name: jnigen
description: A Dart bindings generator for Java and Kotlin that uses JNI under the hood to interop with Java virtual machine.
version: 0.14.1
version: 0.14.2-wip
repository: https://github.com/dart-lang/native/tree/main/pkgs/jnigen
issue_tracker: https://github.com/dart-lang/native/issues?q=is%3Aissue+is%3Aopen+label%3Apackage%3Ajnigen

Expand Down