Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #223

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Update README.md #223

merged 3 commits into from
Apr 12, 2024

Conversation

hanifshahy
Copy link
Contributor

@hanifshahy hanifshahy commented Apr 12, 2024

With this link get 5 more point on https://pub.dev/packages/web/score

  • Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

With this link get 5 more point on https://pub.dev/packages/web/score
Copy link

google-cla bot commented Apr 12, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@srujzs
Copy link
Contributor

srujzs commented Apr 12, 2024

I think we prefer to keep the go-link here if the destination for the URL ever changes. @kevmoo, is that correct?

@kevmoo
Copy link
Member

kevmoo commented Apr 12, 2024

Fixed it! Thank you!

Copy link
Member

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. We can use https on the redirect! 🙏

@kevmoo kevmoo merged commit b53bd7f into dart-lang:main Apr 12, 2024
9 checks passed
@hanifshahy hanifshahy deleted the patch-1 branch April 13, 2024 23:37
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Apr 15, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/ba77660..f339b09):
  f339b094  2024-04-12  Sam Rawlins  Properly sort unnamed libraries (dart-lang/dartdoc#3746)

ecosystem (https://github.com/dart-lang/ecosystem/compare/95fed18..9fabe46):
  9fabe46  2024-04-15  Moritz  Add check for API leaks to the Health workflow (dart-lang/ecosystem#251)

web (https://github.com/dart-lang/web/compare/3d1b4cb..9d8c802):
  9d8c802  2024-04-12  Srujan Gaddam  Only consider extension types that start with JS as JS types (dart-lang/web#224)
  b53bd7f  2024-04-12  M. Hanif Shahy  Update README.md (dart-lang/web#223)

Change-Id: I1009a9acb7fbbf6f276139f1e1a4a5ae2b1e16f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362822
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants