Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local_blockspec() call to 1D TilePattern specialization #693

Merged
merged 2 commits into from
Mar 3, 2020

Conversation

devreal
Copy link
Member

@devreal devreal commented Feb 25, 2020

This is needed for the HDF5 integration to work correctly.

See #692

@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #693 into development will increase coverage by 0.34%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development     #693      +/-   ##
===============================================
+ Coverage        84.07%   84.42%   +0.34%     
===============================================
  Files              336      336              
  Lines            24954    24954              
  Branches         11338    11338              
===============================================
+ Hits             20981    21067      +86     
- Misses            3693     3694       +1     
+ Partials           280      193      -87
Impacted Files Coverage Δ
dart-impl/mpi/src/dart_globmem.c 55.97% <ø> (ø) ⬆️
dart-if/include/dash/dart/if/dart_globmem.h 100% <ø> (ø) ⬆️
dash/test/TestBase.h 65.9% <0%> (-22.73%) ⬇️
...h/include/dash/pattern/internal/PatternArguments.h 78.68% <0%> (-16.4%) ⬇️
dash/include/dash/GlobRef.h 76.99% <0%> (-14.16%) ⬇️
dash/include/dash/Team.h 78.35% <0%> (-10.31%) ⬇️
dash/include/dash/memory/UniquePtr.h 90% <0%> (-10%) ⬇️
dash/include/dash/view/ViewMod.h 92.94% <0%> (-7.06%) ⬇️
dash/include/dash/util/LocalityDomain.h 27.63% <0%> (-6.58%) ⬇️
dash/include/dash/atomic/GlobAtomicRef.h 94.93% <0%> (-5.07%) ⬇️
... and 32 more

@devreal devreal merged commit 2289ce8 into development Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant