Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use new group and var to install dashd_nightly_image on subset of nodes #612

Open
wants to merge 4 commits into
base: v1.0-dev
Choose a base branch
from

Conversation

strophy
Copy link
Collaborator

@strophy strophy commented Dec 23, 2023

Issue being fixed or feature implemented

Core team required latest-nightly images on some nodes

What was done?

Add condition to use dashd_nightly_image on nightly_masternodes

How Has This Been Tested?

On testnet

Breaking Changes

Weird new behaviour?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

ktechmidas
ktechmidas previously approved these changes Dec 23, 2023
Copy link
Contributor

@ktechmidas ktechmidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolute legend, thank you

@shumkov shumkov changed the base branch from v0.25-dev to v1.0-dev January 13, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants