fix: refactor WalletActivity permission launcher to avoid InvalidStat…

…eException (#1239)
dashpay · Dec 15, 2023 · 929ecab · 929ecab
1 parent 2c2839a
commit 929ecab
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/wallet/src/de/schildbach/wallet/ui/main/WalletActivity.java b/wallet/src/de/schildbach/wallet/ui/main/WalletActivity.java
@@ -25,6 +25,8 @@
 import android.os.Bundle;
 import android.os.Handler;
 import android.os.PowerManager;
+import androidx.activity.result.ActivityResultLauncher;
+import androidx.activity.result.contract.ActivityResultContracts;
 import androidx.core.app.ActivityCompat;
 import androidx.lifecycle.ViewModelProvider;
 
@@ -76,6 +78,7 @@ public static Intent createIntent(Context context) {
     private BaseAlertDialogBuilder baseAlertDialogBuilder;
     private MainViewModel viewModel;
 
+    ActivityResultLauncher<String> requestPermissionLauncher = registerForActivityResult(new ActivityResultContracts.RequestPermission(), result -> WalletActivityExt.INSTANCE.requestDisableBatteryOptimisation(WalletActivity.this));
 
     @Override
     protected void onCreate(final Bundle savedInstanceState) {

diff --git a/wallet/src/de/schildbach/wallet/ui/main/WalletActivityExt.kt b/wallet/src/de/schildbach/wallet/ui/main/WalletActivityExt.kt
@@ -203,11 +203,6 @@ object WalletActivityExt {
         }
     }
 
-    private val WalletActivity.requestPermissionLauncher: ActivityResultLauncher<String>
-        get() = registerForActivityResult(ActivityResultContracts.RequestPermission()) {
-            requestDisableBatteryOptimisation()
-        }
-
     /**
      * Android 13 - Show system dialog to get notification permission from user, if not granted
      * ask again with each app upgrade if not granted.  This logic is handled by
@@ -238,7 +233,7 @@ object WalletActivityExt {
         configuration.showNotificationsExplainer = false
     }
 
-    private fun WalletActivity.requestDisableBatteryOptimisation() {
+    fun WalletActivity.requestDisableBatteryOptimisation() {
         val powerManager: PowerManager = getSystemService(PowerManager::class.java)
         if (ContextCompat.checkSelfPermission(
                 walletApplication,