feat(dashpay): add timeskew support to CoinJoinService and warning dialogs #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashEngineering
commented
Feb 1, 2024
Comment on lines
-535
to
-540
| private fun checkLowStorageAlert() { | ||
| val stickyIntent = registerReceiver(null, IntentFilter(Intent.ACTION_DEVICE_STORAGE_LOW)) | ||
| if (stickyIntent != null) { | ||
| showLowStorageAlertDialog() | ||
| } | ||
| } |
There was a problem hiding this comment.
DashPay was using the old checkLowStorageAlert()
HashEngineering
commented
Feb 1, 2024
Comment on lines
394
to
400
| val maxAllowedTimeSkew = if (coinJoinConfig.getMode() == CoinJoinMode.NONE) { | ||
| TIME_SKEW_TOLERANCE | ||
| } else { | ||
| TIME_SKEW_TOLERANCE_COINJOIN | ||
| } | ||
| val timeSkew = abs(systemTimeMillis - networkTime) / 1000 | ||
| return Pair(timeSkew > maxAllowedTimeSkew, timeSkew) |
There was a problem hiding this comment.
for the MainActivity we will show one message if CoinJoin is ON, and another if OFF. Each has different tolerances.
HashEngineering
commented
Feb 1, 2024
Comment on lines
257
to
286
| if (mode == CoinJoinMode.NONE) { | ||
| if (mode == CoinJoinMode.NONE || timeSkew > MAX_ALLOWED_TIMESKEW) { |
There was a problem hiding this comment.
we will use timeSkew to determine if CoinJoin will actually run or not.
timeSkew > 2 seconds will give the same result as CoinJoin OFF.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Related PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist: