fix(dashpay): improve progress UI for mixing and otherfixes timeskew progress #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashEngineering
commented
Feb 28, 2024
Comment on lines
+50
to
66
| var timeSource = "NTP" | ||
|
|
||
| val networkTimes = arrayListOf<Long>() | ||
| for (i in 0..3) { | ||
| try { | ||
| val time = queryNtpTime("pool.ntp.org") | ||
| if (time != null && time > 0) { networkTimes.add(time) } | ||
| } catch (e: SocketTimeoutException) { | ||
| // swallow | ||
| } | ||
| } | ||
| networkTimes.sort() | ||
| when (networkTimes.size) { | ||
| 3 -> networkTime = networkTimes[2] | ||
| 2 -> networkTime = (networkTimes[0] + networkTimes[1]) / 2 | ||
| else -> { } | ||
| } |
There was a problem hiding this comment.
perhaps later we should use the same mechanism of Dash Core for timeskew, as this gets complicated.
Sometimes the NTP server returns a number less than zero, so this is ignored.
Sometimes when the app starts up, there is a dialog about 6 or 7 second timeskew, but subsequent calls return 1 or 2 seconds difference.
HashEngineering
commented
Feb 28, 2024
Comment on lines
+1
to
+10
| <vector xmlns:android="http://schemas.android.com/apk/res/android" | ||
| android:width="12dp" | ||
| android:height="12dp" | ||
| android:viewportWidth="12" | ||
| android:viewportHeight="12"> | ||
| <path | ||
| android:pathData="M6.416,1.314C5.561,1.238 4.702,1.398 3.931,1.775C3.16,2.153 2.507,2.734 2.043,3.456C1.579,4.178 1.321,5.013 1.298,5.871C1.274,6.729 1.486,7.577 1.909,8.323L0.783,8.963C0.242,8.011 -0.028,6.929 0.002,5.835C0.032,4.741 0.361,3.676 0.953,2.755C1.545,1.834 2.378,1.093 3.361,0.611C4.344,0.13 5.44,-0.073 6.531,0.024L6.416,1.314Z" | ||
| android:fillColor="#008DE4" | ||
| android:fillType="evenOdd"/> | ||
| </vector> |
There was a problem hiding this comment.
I thought we had a circular progress indicator, but couldn't find it. I remember adding it to Coinbase.
Syn-McJ
approved these changes
Feb 29, 2024
Syn-McJ
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Related PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist: